Closed
Conversation
scotwells
reviewed
Jan 16, 2026
Contributor
scotwells
left a comment
There was a problem hiding this comment.
Matches my understanding of how things are things are supposed to work. This should be in the enhancements repo though since it spans multiple software components.
joshlreese
reviewed
Jan 17, 2026
Contributor
Author
|
Opened this enhancement to cover this implementation: datum-cloud/enhancements#556 @joshlreese I should have covered your initial questions/comments but feel free to start threads there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connector and Envoy Integration Design:
docs/connector-envoy-design.md) detailing howConnectorandConnectorAdvertisementresources are used to route traffic through Envoy and an iroh sidecar, including the data path, sidecar responsibilities, route metadata contract, and validation rules.End-to-End Flow Documentation:
docs/connector-e2e-flow.md) outlining the tunnel lifecycle, responsibilities of each component (Device Agent, Control Plane, NSO, Envoy), and the data exchanged at each step.NSO Work Plan and Implementation Steps:
docs/nso-connector-work.md) specifying new controllers, reconciliation logic, validation, Gateway API programming, and required API updates to enable connector-aware routing in NSO. Also includes an MVP checklist for implementation.